Repository navigation
ods: preserve displayed text for cached error cells - #739
Merged
jmcnamara merged 2 commits intoOct 29, 2026
Merged
Conversation
Collaborator
|
Is this related to #744? |
jmcnamara
requested changes
Oct 18, 2026
Contributor
Author
|
Moved the regression to #744 fixes a separate issue: XML whitespace between cells in Verified that the fixture test fails on the original reader and passes with this fix. These commands pass locally:
|
Collaborator
|
Merged. Thanks. |
Collaborator
|
Fixed/merged upstream in v0.38.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #720.
LibreOffice error cells can have an empty
office:string-valuewhile their displayed error is stored in<text:p>. Read that text whencalcext:value-type="error"is present, preserving values such as#DIV/0!asData::Stringinstead of returning an empty string.Changes
Testing
cargo test --all-features --test test ods_cached_error_textcargo test --all-featurescargo buildcargo fmt -- --checkcargo clippy --all-targets --all-features -- -DwarningsRun locally on macOS arm64 with Rust 1.95.0. The existing ignored test remains ignored; other toolchains and the WASM CI target were not run locally.