Skip to content

ods: accept XML whitespace between cells - #744

Merged
jmcnamara merged 1 commit into
tafia:masterfrom
Goldziher:fix/ods-row-xml-whitespace
Nov 14, 2026
Merged

jmcnamara merged 1 commit into
tafia:masterfrom
Goldziher:fix/ods-row-xml-whitespace

Conversation

@Goldziher

@Goldziher Goldziher commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #743 by accepting XML whitespace between ODS cells while preserving cell text and rejecting unexpected row text. The regression uses checked-in ODS workbooks under tests/ and runs in tests/test.rs.

The whitespace test fails with the previous parser. At 9073801, cargo test --all-features and cargo fmt -- --check pass.

Copilot AI balanced review requested due to automatic review settings October 16, 2026 16:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@jmcnamara jmcnamara added the needs work for merge The PR needs some rework or clarification. No suitable for merge, yet. label Oct 17, 2026
@jmcnamara

Copy link
Copy Markdown
Collaborator

Just a head up that adding a new tests/fixtures dir isn't desirable. Instead create a ods file with the issues being fixed and add it to the standard tests/test.rs tests.

@jmcnamara

Copy link
Copy Markdown
Collaborator

Also, is this related to #739?

Comment thread tests/ods_whitespace.rs Resolved
@jmcnamara

Copy link
Copy Markdown
Collaborator

@Goldziher Ping.

@Goldziher

Copy link
Copy Markdown
Contributor Author

@Goldziher Ping.

Saw it now, will update

@Goldziher

Copy link
Copy Markdown
Contributor Author

@jmcnamara I pushed the fixture changes in 9073801. The regression now uses checked-in ODS files under tests/ and runs in tests/test.rs. This fixes XML whitespace between cells. #739 handles cached error text inside a cell. The full all-features test suite passed locally.

Comment thread tests/test.rs Resolved
Comment thread tests/test.rs Resolved
Comment thread tests/test.rs Resolved
@Goldziher
Goldziher requested a review from jmcnamara November 14, 2026 13:14
@jmcnamara

Copy link
Copy Markdown
Collaborator

@Goldziher Looks good now. However, there is a conflict with the tests.rs file since another test was merged before the ones in this PR.

Could you resolve that, and also squash your commits down into one.

Whitespace-only text between cell elements in a row made the reader fail with a table-cell mismatch. Skip XML whitespace there; other text and non-XML whitespace are still rejected.
@Goldziher
Goldziher force-pushed the fix/ods-row-xml-whitespace branch from 8d9375f to eddb258 Compare November 14, 2026 17:36
@jmcnamara
jmcnamara merged commit 93e2e6b into tafia:master Nov 14, 2026
6 checks passed
@jmcnamara

Copy link
Copy Markdown
Collaborator

@Goldziher Merged. Thanks.

@jmcnamara jmcnamara removed the needs work for merge The PR needs some rework or clarification. No suitable for merge, yet. label Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ODS: indented table rows fail on inter-cell XML whitespace

3 participants