Repository navigation
ods: accept XML whitespace between cells - #744
Conversation
|
Just a head up that adding a new |
|
Also, is this related to #739? |
|
@Goldziher Ping. |
Saw it now, will update |
|
@jmcnamara I pushed the fixture changes in 9073801. The regression now uses checked-in ODS files under tests/ and runs in tests/test.rs. This fixes XML whitespace between cells. #739 handles cached error text inside a cell. The full all-features test suite passed locally. |
|
@Goldziher Looks good now. However, there is a conflict with the tests.rs file since another test was merged before the ones in this PR. Could you resolve that, and also squash your commits down into one. |
Whitespace-only text between cell elements in a row made the reader fail with a table-cell mismatch. Skip XML whitespace there; other text and non-XML whitespace are still rejected.
8d9375f to
eddb258
Compare
|
@Goldziher Merged. Thanks. |
Fixes #743 by accepting XML whitespace between ODS cells while preserving cell text and rejecting unexpected row text. The regression uses checked-in ODS workbooks under tests/ and runs in tests/test.rs.
The whitespace test fails with the previous parser. At 9073801, cargo test --all-features and cargo fmt -- --check pass.