Editorial: change return value of SetViewValue from undefined to unused - #3981
Merged
Merged
Conversation
bakkot
approved these changes
Sep 20, 2026
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3981 and as multiple pages at https://tc39.es/ecma262/pr/3981/multipage . |
nicolo-ribaudo
approved these changes
Sep 20, 2026
linusg
approved these changes
Sep 20, 2026
linusg
added
editorial change
ready to merge
ljharb
force-pushed
the
SetViewValue
branch
from
September 20, 2026 12:17
9871958 to
726ec8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this when refactoring engine262. The return value of this AO does not represent a meaningful ECMAScript value; therefore, I think it is better to change it as in this PR.