Skip to content

Editorial: change return value of SetViewValue from undefined to unused #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ljharb merged 1 commit into from
Sep 20, 2026
+24 −13
Merged

Editorial: change return value of SetViewValue from undefined to unused #3981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46628,7 +46628,7 @@ <h1>
_isLittleEndian_: an ECMAScript language value,
_type_: a TypedArray element type,
_value_: an ECMAScript language value,
): either a normal completion containing *undefined* or a throw completion
): either a normal completion containing ~unused~ or a throw completion
</h1>
<dl class="header">
<dt>description</dt>
Expand All @@ -46650,7 +46650,7 @@ <h1>
1. If _getIndex_ + _elementSize_ > _viewSize_, throw a *RangeError* exception.
1. Let _bufferIndex_ be _getIndex_ + _viewOffset_.
1. Perform SetValueInBuffer(_view_.[[ViewedArrayBuffer]], _bufferIndex_, _type_, _number_, *false*, ~unordered~, _isLittleEndian_).
1. Return *undefined*.
1. Return ~unused~.
</emu-alg>
</emu-clause>
</emu-clause>
Expand Down Expand Up @@ -46880,7 +46880,8 @@ <h1>DataView.prototype.setBigInt64 ( _byteOffset_, _value_ [ , _littleEndian_ ]
<p>This method performs the following steps when called:</p>
<emu-alg>
1. Let _view_ be the *this* value.
1. Return ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~bigint64~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~bigint64~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand All @@ -46889,7 +46890,8 @@ <h1>DataView.prototype.setBigUint64 ( _byteOffset_, _value_ [ , _littleEndian_ ]
<p>This method performs the following steps when called:</p>
<emu-alg>
1. Let _view_ be the *this* value.
1. Return ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~biguint64~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~biguint64~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand All @@ -46899,7 +46901,8 @@ <h1>DataView.prototype.setFloat16 ( _byteOffset_, _value_ [ , _littleEndian_ ] )
<emu-alg>
1. Let _view_ be the *this* value.
1. If _littleEndian_ is not present, set _littleEndian_ to *false*.
1. Return ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~float16~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~float16~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand All @@ -46909,7 +46912,8 @@ <h1>DataView.prototype.setFloat32 ( _byteOffset_, _value_ [ , _littleEndian_ ] )
<emu-alg>
1. Let _view_ be the *this* value.
1. If _littleEndian_ is not present, set _littleEndian_ to *false*.
1. Return ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~float32~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~float32~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand All @@ -46919,7 +46923,8 @@ <h1>DataView.prototype.setFloat64 ( _byteOffset_, _value_ [ , _littleEndian_ ] )
<emu-alg>
1. Let _view_ be the *this* value.
1. If _littleEndian_ is not present, set _littleEndian_ to *false*.
1. Return ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~float64~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~float64~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand All @@ -46928,7 +46933,8 @@ <h1>DataView.prototype.setInt8 ( _byteOffset_, _value_ )</h1>
<p>This method performs the following steps when called:</p>
<emu-alg>
1. Let _view_ be the *this* value.
1. Return ? SetViewValue(_view_, _byteOffset_, *true*, ~int8~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, *true*, ~int8~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand All @@ -46938,7 +46944,8 @@ <h1>DataView.prototype.setInt16 ( _byteOffset_, _value_ [ , _littleEndian_ ] )</
<emu-alg>
1. Let _view_ be the *this* value.
1. If _littleEndian_ is not present, set _littleEndian_ to *false*.
1. Return ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~int16~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~int16~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand All @@ -46948,7 +46955,8 @@ <h1>DataView.prototype.setInt32 ( _byteOffset_, _value_ [ , _littleEndian_ ] )</
<emu-alg>
1. Let _view_ be the *this* value.
1. If _littleEndian_ is not present, set _littleEndian_ to *false*.
1. Return ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~int32~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~int32~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand All @@ -46957,7 +46965,8 @@ <h1>DataView.prototype.setUint8 ( _byteOffset_, _value_ )</h1>
<p>This method performs the following steps when called:</p>
<emu-alg>
1. Let _view_ be the *this* value.
1. Return ? SetViewValue(_view_, _byteOffset_, *true*, ~uint8~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, *true*, ~uint8~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand All @@ -46967,7 +46976,8 @@ <h1>DataView.prototype.setUint16 ( _byteOffset_, _value_ [ , _littleEndian_ ] )<
<emu-alg>
1. Let _view_ be the *this* value.
1. If _littleEndian_ is not present, set _littleEndian_ to *false*.
1. Return ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~uint16~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~uint16~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand All @@ -46977,7 +46987,8 @@ <h1>DataView.prototype.setUint32 ( _byteOffset_, _value_ [ , _littleEndian_ ] )<
<emu-alg>
1. Let _view_ be the *this* value.
1. If _littleEndian_ is not present, set _littleEndian_ to *false*.
1. Return ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~uint32~, _value_).
1. Perform ? SetViewValue(_view_, _byteOffset_, _littleEndian_, ~uint32~, _value_).
1. Return *undefined*.
</emu-alg>
</emu-clause>

Expand Down
Loading