Repository navigation
fix(veracrypt): take the version from the Linux h4, not the markup - #2065
Conversation
The Downloads page now renders 'Latest Stable Release' as a bare <h3> heading, so the old \S+ grab made </h3> the version and the download URL 404'd (wimpysworld#2064). Anchor on the <h4> Linux line below it and require a leading digit; head -n1 in case another line ever matches. Closes wimpysworld#2064
|
See #2064 (comment), probably not a good idea if it's temporary. |
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Fixes VeraCrypt version extraction in both package scripts by anchoring on the Linux
line and requiring a leading digit, preventing HTML markup from building a 404 URL. The diff is focused, clearly corrects the reported bug, and changes no broader behavior.
Re-trigger cubic
Review noted the site may go back to the one-line form, so keep the original Latest-Stable-Release extraction (now digit-anchored) and fall back to the <h4> Linux line only when the first comes up empty. POSIX character classes throughout, so no backslash escaping in the sed programs.
|
Reworked in 7e363aa per the concern that the bare- |
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Fixes VeraCrypt version extraction in both package scripts by requiring a leading digit and falling back to the Linux
line, preventing HTML markup from building a 404 Launchpad URL. Focused bug fix with no broader behavior change.
Re-trigger cubic
|
Thanks @bfs2021 and @GideonBear ! |
Problem
deb-get install veracryptextracted</h3>as the version and built a 404ing Launchpad URL (.../trunk/</h3>/+download/...). The Downloads page now renders "Latest Stable Release" as a bare<h3>…</h3>heading, so the old\S+grab — with\s*and-?all optional — matched the heading's closing tag instead of a version (#2064).Fix
Both
veracryptandveracrypt-consoleanchor on the<h4>Linux…line that follows the heading (the macOS line above it carries a different, newer version and must not match) and require a leading digit:VERSION_PUBLISHED=$(sed -En 's|.*<h4>Linux[^-]*-\s*([0-9][0-9.]*).*|\1|p' "${CACHE_FILE}" | head -n1)Testing
Against the live page as of today: the old expression yields
</h3>; the new one yields1.26.29(the Linux release the URL is built from). Verified by running both expressions over a fresh download ofDownloads.html;bash -npasses on both files, and the PR's package CI will exercise the real flow.Closes #2064