Repository navigation
fix python porthandler bug - #682
Merged
Merged
Conversation
…in PortHandler class
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Dynamixel SDK version to 4.0.5 across all supported platforms and languages, including C, C++, Python, and ROS packages. The primary functional change is the update of the clearPort() method in the Python PortHandler to use reset_input_buffer() instead of flush(). Review feedback suggests adding a safety check to ensure the serial port is open before attempting to clear the buffer, which would prevent potential exceptions if the method is called on a closed port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Python PortHandler, the clearPort() function is used to clear the receive buffer before sending a new packet so that the status packet can be received cleanly. Since flush() is not intended for this purpose, we will modify the function accordingly.