Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #7138 and #7139
Just an idea - this is something I've seen with Django for instance, you (in most cases) only modify the Python models and then run
makemigrationsandmigrateand it generates the corresponding SQL tables or schema changes. This PR adds the same kind of thing but generating the SQL migration from the Exposed table definitions.This would add a command that can be run as follows:
which computes the difference between the existing DB schema and the exposed table definitions, and creates a migration for it.
This is not something that could be merged yet as the Exposed definitions miss a lot of the DB schema, and the generated migration would remove constraints and columns from the database. Exposed needs to be in line with the DB schema (i.e. with PR #7138), but this might be useful after, if we want to remove having to write SQL and Exposed definitions. Although I guess with Claude you can now just ask it to write the corresponding SQL for you anyway 🙃
Screenshot
PR Checklist
🚀 Preview: Add
previewlabel to enable